Giter Club home page Giter Club logo

Comments (7)

Terkwood avatar Terkwood commented on August 18, 2024 2

Yeah, I appreciate that Microsoft has given us such a nice tool in Github Actions, but their compute power is limited! I proposed a fix in #165, which apparently passes on the first try here in Githubland. Let me know what you think.

from redis.

Terkwood avatar Terkwood commented on August 18, 2024 1

...and even before that. And some other tests are passing in between the failures. So, yes, it's definitely not predictable enough. I'll work on reproducing this locally

from redis.

Terkwood avatar Terkwood commented on August 18, 2024 1

Not surprisingly, this works locally on an aging MacBook Pro. I would guess that my local environment has a bit more power than the Github Actions environment. My next step would be to look at the timing expectations around the Github Actions test runs... It's been a little while since I've been in this code base, but this seems like a classic integration testing situation 😁 🤓 ⌚

from redis.

uki00a avatar uki00a commented on August 18, 2024 1

This worked well on my local machine! (Ubuntu 20.04) I'll look into it too 😉

from redis.

Terkwood avatar Terkwood commented on August 18, 2024

Oo, interesting, did this test behavior change recently? Or has it been misbehaving for a while now?

from redis.

Terkwood avatar Terkwood commented on August 18, 2024

I see this going back to https://github.com/denodrivers/redis/runs/1523779037?check_suite_focus=true (20 days ago), at least

from redis.

Terkwood avatar Terkwood commented on August 18, 2024

We already have delay statements in the run. I would like to push a change set which increases these values and then see how it performs under github actions

await delay(5);

from redis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.