Github broke extension again about makegithubgreatagain HOT 15 CLOSED

Yeah, thats true. I forgot

from makegithubgreatagain.

I was just about to post this.... it looks like they're now nesting the header. The selector should now instead be something like body > div > .header or perhaps body div.header.

from makegithubgreatagain.

Its body > div > .header (https://developer.mozilla.org/en-US/docs/Learn/CSS/Introduction_to_CSS/Combinators_and_multiple_selectors)

from makegithubgreatagain.

Would it not be better just making it .header, effectively future proofing this from changes in the HTML layout?

from makegithubgreatagain.

Perhaps an extension option to customize the selector?

from makegithubgreatagain.

I'd say that absolutely referencing the element is not a good practice, as it's better to have "modular" CSS and nothing else on the page has the .header class.

from makegithubgreatagain.

How would that work exactly? The only way you can reliable detect the header is by using the .header class (or other classes pertaining to the header), so I don't see why we don't just go for .header on it's own.

from makegithubgreatagain.

If you publish using the Chrome Developer Dashboard, you can ignore this page.

And this extension is published using the dashboard, so I don't see what your point is?

from makegithubgreatagain.

Maybe another method to access .header should be used. GitHub could patch the extension by just renaming the class. However, certain things about the header are constant, they dont change.

from makegithubgreatagain.

I doubt they'll rename the .header class, it's a sensible name for it. They've kept it when doing the styling changes so I don't see why they'd change it again. I guess you could look it up by it's banner role too.

from makegithubgreatagain.

Mark Otto seems to be feisty about it though. (https://twitter.com/mdo/status/830138373230653440)

from makegithubgreatagain.

Yeah I get that, but the current class is sensible and hasn't changed even with all of the changes they've implemented. Having a more vague selector means we don't need to change the extension when (minor) HTML changes are made.

from makegithubgreatagain.

Okay. Also, maybe this project should port to stylus (https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne). This is because GitHub is going to change more stuff that we might not like, and it would be harder for this project if it is a standalone extension.

from makegithubgreatagain.

https://github.com/StylishThemes/GitHub-Dark uses it

from makegithubgreatagain.

Fixed now, chrome extension store update coming soon!

from makegithubgreatagain.