Giter Club home page Giter Club logo

Comments (9)

santisiri avatar santisiri commented on June 15, 2024 4

Feature implemented, audited and tested. Closing.

from ubi.

mdalie avatar mdalie commented on June 15, 2024 2

That sounds pretty awesome @auryn-macmillan, we would be glad to help you integrate Superfluid. @santisiri join our Discord so we can talk about it.

from ubi.

santisiri avatar santisiri commented on June 15, 2024 2

eppur si muove: https://twitter.com/santisiri/status/1363503509145079811

thanks for pushing me in this direction @auryn-macmillan !

from ubi.

mdalie avatar mdalie commented on June 15, 2024 1

I see on Discord that you and our champion @pi0neerpat are on it, shout if you have any issues.

from ubi.

auryn-macmillan avatar auryn-macmillan commented on June 15, 2024 1

This is awesome!

from ubi.

santisiri avatar santisiri commented on June 15, 2024

Will definitely explore this possibility. This is a great idea @auryn-macmillan !

from ubi.

santisiri avatar santisiri commented on June 15, 2024

Working my way through the documentation to test superTokens.. stuck here for time being: superfluid-finance/protocol-monorepo#230

from ubi.

santisiri avatar santisiri commented on June 15, 2024

Been testing this out and looking at the contracts. Since we know that our ubi contract can mint tokens throughout time to valid identities, been thinking we could simply implement the functionality related to realtimeBalanceOf:

function balanceOf(
        address account
    )
        public
        view
        override
        returns(uint256 balance)
    {
        // solhint-disable-next-line not-rely-on-time
        (int256 availableBalance, , ) = super.realtimeBalanceOf(account, block.timestamp);
        return availableBalance < 0 ? 0 : uint256(availableBalance);
    }

Though for this I'd like to have a clearer picture for security precautions we need to consider. Probably making this optional on a first version makes sense cc @epiqueras.

from ubi.

santisiri avatar santisiri commented on June 15, 2024

Implemented a very simple version that directly displays accrued value on balanceOf — pull available here: #73

from ubi.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.