[BUG] Contents of directories are not merged if one with such name exists about amarok-hider HOT 3 OPEN

@nvllz 👏 Thanks for the report.

My concern: If we merge the folders, what should we do if both the folders contain a file that has the same name?
We can just skip the duplicated ones and merge the rest — however that may cause confusion:

An example: Many users use Amarok to hide visual novel game data. If a user starts the launcher by accident when data is still in the hidden state, the launcher is expected to produce lots of configs or log files. These files have the same name as the hidden ones. And merging them could lead to game data corruption which is hard to fix. If we just leave the merge task to the user, the user can simply delete the newly generated folder.

And my solution to your problem: set all the inner nested folders (like DCIM/Screenshots) rather than the outmost one (DCIM) to hide. Amarok doesn't apply obfuscation to the folder directly set to hide, it just hides the folder contents. Yeah that may have several drawbacks, but that's better than the data corruption.

from amarok-hider.

An example: Many users use Amarok to hide visual novel game data. If a user starts the launcher by accident when data is still in the hidden state, the launcher is expected to produce lots of configs or log files. These files have the same name as the hidden ones. And merging them could lead to game data corruption which is hard to fix. If we just leave the merge task to the user, the user can simply delete the newly generated folder.

The only solution I can think of is to first check for any files before processing if there is already a catalog with the same name, and if there are any files there, let the user decide whether to merge or skip processing for that catalog. If it's too complex, If it's too complex, I can stick to what you said below, but the hiding of the folder name is one thing that I would like to achieve here.

from amarok-hider.

let the user decide whether to merge or skip processing for that catalog

That's where the problem is. The hiding process is performed in a background thread (so it can be triggered by the QuickSettings switch or the PanicButton). Popping out a dialog from background service is generally discouraged by Android and has lots of limitations. Instead, I can try sending a notification to notify the user about the failure & provide a button to auto-merge the folders — no guarantee, I'll have a try later.

from amarok-hider.