Giter Club home page Giter Club logo

Comments (2)

bacongobbler avatar bacongobbler commented on August 11, 2024

I think this is exactly the reason why we decided to put that big fat warning in there. The client is not guaranteed to work with older releases, and we highly recommend upgrading in lock-step, but occasionally older clients can be used to talk to newer servers since the API shouldn't change significantly.

That being said, I don't see any reason why this would be broken according to deis/controller@v2.0.0...v2.1.0. The only relevant change I've seen server-side is in deis/controller@46829d3 and that was in 2.0.0-alpha, so I'm at a loss how a 2.1 client would fail to save the token from a 2.0 server. I'll see if I can replicate :)

from workflow-cli.

Joshua-Anderson avatar Joshua-Anderson commented on August 11, 2024

Ok. I figured out the problem.... I screwed up 😦. When the request returns a version mismatch, it returns that error in addation to the response. When the methods get the error response they immediately bail out and don't attempt to parse the body.

The CLI on the other hand, checks to see if the error is an API mismatch, and if there is, recognizes it is a warning and continues on, even though they're only working with a blank object.

What the SDK should do is implement a method similar to the workflow-cli's checkAPICompatibility which checks if the the error is an api compatibility one before bailing out.

from workflow-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.