Giter Club home page Giter Club logo

Comments (2)

krancour avatar krancour commented on June 2, 2024

Just wanted to quickly comment that I had not lost track of this. I desperately want to add these tests as well, but figuring out how to test things that have dependencies on the k8s API has been elusive. I think this is going to be the subject of some discussion as a team next week.

from router.

krancour avatar krancour commented on June 2, 2024

#104 introduced some tests against the model. They revolve mainly around validation. The model uses a very declarative style, so these tests don't do much to increase coverage. (And interesting example of how coverage numbers can lie to you.)

The original issue here though does revolve more around actual imperative logic that is not covered by unit tests, but unless I am mistaken, we're resigned at this point to the notion that code that interacts with k8s will be covered by e2e tests instead.

My feeling is that this should be closed in light of the above, but can be re-opened someday if the possibility of testing the model in isolation from k8s becomes a more realistic possibility.

from router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.