Giter Club home page Giter Club logo

Comments (6)

helgi avatar helgi commented on June 18, 2024

That's fine but then you are moving into a config map / annotations instead of it being a label selector, which the k8s API has a much easier time to query against.

Don't think JSONPath is part of the API and only kubectl. If that was around we could do many more powerful things on random things

from router.

krancour avatar krancour commented on June 18, 2024

@helgi I wasn't proposing that it no longer be a label. Labels definitely make for more efficient queries. Do you know something I don't? Like, perhaps, would router.deis.io/routable be an invalid label? I need to check.

from router.

helgi avatar helgi commented on June 18, 2024

I have to look again but labels are DNS labels iirc, dots not are allowed in that case. It may be considered a subdomain label, which changes the game :)

from router.

helgi avatar helgi commented on June 18, 2024

Is the primary reasoning for this to be more identifiable as to what routable is and for who it is?

from router.

krancour avatar krancour commented on June 18, 2024

Yes. We've done the same for annotations. It seems we should do so here as well for consistency.

from router.

helgi avatar helgi commented on June 18, 2024

Part of me feels it's cruft and could get us into some odd scenarios down the line but at the same time it make sense

from router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.