Giter Club home page Giter Club logo

Comments (9)

flyboarder avatar flyboarder commented on May 29, 2024

In your example you are using the current directory as the execution location for boot exec. This is where your error is, that directory should be a temporary location made with something like (tmp-dir!).

from boot-exec.

svdm avatar svdm commented on May 29, 2024

I understand, but there are some commands you have to run outside of a tempdir. For example, git commands must run in the repo root. It's what boot-semgit is doing e.g. here https://github.com/degree9/boot-semgit/blob/master/src/degree9/boot_semgit.clj#L16

So right now, using one of those git tasks adds your whole repo to the fileset. I could also report that as a bug in boot-semgit, but there's no way to fix it there without some change in boot-exec to make it not add-resource the current directory.

from boot-exec.

flyboarder avatar flyboarder commented on May 29, 2024

Try the version currently in master, i think this will need to be solved in semgit tho.

from boot-exec.

svdm avatar svdm commented on May 29, 2024

I was using 0.4.0, compared to that master only includes some readme-related commits, so I don't think that'll help.

Anyway, if this is intended behaviour I'll just write some tasks that use clj-jgit instead of exec'ing the binary. I'll close this issue.

from boot-exec.

flyboarder avatar flyboarder commented on May 29, 2024

The new version has an include option which should solve your problem, I'll do a push to clojars today. Also I'd be willing to accept jgit PR's for boot-semgit.

from boot-exec.

svdm avatar svdm commented on May 29, 2024

Thanks for adding the option, but I think you haven't pushed it to github? The newest commit here is still 06d27dd.

from boot-exec.

flyboarder avatar flyboarder commented on May 29, 2024

@svdm sorry it was in my personal repo, flyboarder/boot-exec I have merged it in here, can you take a look?

from boot-exec.

svdm avatar svdm commented on May 29, 2024

Thanks, it works fine. You could opt to make include enabled by default, so as not to break backwards compatibility (doesn't make a difference for me, but I guess someone might be relying on it).

I did look into jgit, but any interaction with the remote that requires authentication is a major hassle, because you can't rely on git handling things (so you have to explicitly connect to a running ssh-agent, else fall back, etc etc). That's probably why clj-jgit doesn't offer any bindings for e.g. pushing. So right now calling the binary is by far the more practical way to make it Just Work.

from boot-exec.

flyboarder avatar flyboarder commented on May 29, 2024

This should now be solved.

from boot-exec.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.