Giter Club home page Giter Club logo

Comments (3)

github-actions avatar github-actions commented on June 2, 2024

Thank you for raising your first issue! Your help to improve svglib is much appreciated!

from svglib.

claudep avatar claudep commented on June 2, 2024

You are right, if paths in the content are absolute paths, we should not fail with that message (around

if iri:
). Do you want to suggest a patch to fix this?

from svglib.

hatersDuck avatar hatersDuck commented on June 2, 2024

I suck at handling forked changes, so I'm just gonna dump the code here.

These changes really helped me out. Write that up as lit.

reworked lines 707-722

        if iri:
            import io
            # Only local relative paths and BytesIO objects are supported
            if not isinstance(self.source_path, (str, io.BytesIO)):
                logger.error(
                    "Unable to resolve image path %r as the SVG source is not "
                    "a file system path or BytesIO object.",
                    iri
                )
                return None
            
            if isinstance(self.source_path, str):
                path = os.path.normpath(os.path.join(os.path.dirname(self.source_path), iri))
                if not os.access(path, os.R_OK):
                    return None
                if path == self.source_path:
                    # Self-referencing, ignore the IRI part
                    iri = None
            else:
                # self.source_path is of type io.BytesIO
                # We need to read the data from BytesIO object so that it can be accessed like a regular file system path.
                try:
                    path = self.source_path.name
                except AttributeError:
                    path = '<BytesIO>'
                with open(path, 'wb') as f:
                    f.write(self.source_path.read())
                
                path = os.path.normpath(os.path.join(os.path.dirname(path), iri))
                if path == '<BytesIO>':
                    iri = None
                elif not os.access(path, os.R_OK):
                    return None

from svglib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.