Make external an available option about gulp-browserify HOT 9 CLOSED

https://github.com/substack/node-browserify/blob/master/bin/args.js#L84 if i have made it as an option i would be doing something similar and logic wise i dnt think its much of a difference from what you have written. I just want the developers to use browserify options in their own way. But i am open to suggestions :)

from gulp-browserify.

So I should ping browserify guys if they would consider adding externals to bundle()?

from gulp-browserify.

Are you facing scenarios where the current option of using externals not proving helpful ??

from gulp-browserify.

node-browserify has 3 types of options.

1. constructor options
2. bundle options
3. methods like external, require and etc.

I think it would be nice if we decide a guideline to handle them. Currently we do 2 and some of 3 in the first argument,1 in the second argument and the rest of 3 in prebunfle hook.

Clearer ways would be

A. Put everything in one object argument and this plugin manages the 3 types.
B. Have separate arguments for node-browserify options.1 on the second argument, 2 on the first argument and 3 on the prebundle hook.

What do you guys think?

from gulp-browserify.

I think we shld shift to A so that the plugin will be future compatible with browserify.

from gulp-browserify.

That would result in my proposal working, yes?

from gulp-browserify.

@xixixao yes it would :)

from gulp-browserify.

I'd love to have external and require treated as regular options!

from gulp-browserify.

It seems that external and require were supported by #38.

from gulp-browserify.