Giter Club home page Giter Club logo

Comments (4)

deckarep avatar deckarep commented on August 24, 2024 1

from golang-set.

deckarep avatar deckarep commented on August 24, 2024 1

@ScreamingHawk - circling back on this seems like this would be a fairly large breaking change. I understand what your concern is but I do feel like this would possibly complicate the API. I'm still thinking about it.

from golang-set.

deckarep avatar deckarep commented on August 24, 2024

Hello,

Thanks for the recommendation! I'm certainly not opposed to changes that would be considered general enough that others would find useful and if you have an API in mind I'd love to hear more details.

This package is so widely used it would be help to get more context and allow others to chime in.

from golang-set.

ScreamingHawk avatar ScreamingHawk commented on August 24, 2024

Here's some pseudo code for the pattern I've got. Please forgive errors.

type Entity struct {
  ID        uint64
  Data1 string
  Data2 bool
  // ...
  UpdatedAt *time.Time
}

func Update(apiEntities []*Entity) error {
  dbEntities = db.ListEntities()
  origSet := mapset.NewSet(dbEntities...)
  updateSet := mapset.NewSet(apiEntities...)

  added := updateSet.Difference(origSet)
  // Process newly added entries

  removed := origSet.Difference(updateSet)
  // Process deleted entries
}

Entity's that come in via the API don't have an ID populated, this causes all data to not match.
Also in this case UpdatedAt should be ignored when looking for equality.

If we could pass a function to do the comparison, that would be a nice general solution.
Something like:

func entityEqual(a Entity, b Entity) bool {
  // Whatever logic here
  return a.Data1 == b.Data1 && a.Data2 == b.Data2
}

func Update(apiEntities []*Entity) error {
  // ...
  added := updateSet.Difference(origSet, entityEqual)
  // ...
}

from golang-set.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.