Comments (10)
maraoz
commented on August 30, 2024
ACK, ping @federicobond
from mana.
federicobond
commented on August 30, 2024
Pausable is Ownable, but the token is owned by the Crowdsale contract. We can forward those pause/unpause calls via pauseToken/unpauseToken methods in the crowdsale.
from mana.
maraoz
commented on August 30, 2024
IMO, token should be paused right after construction, and only unpaused manually after the crowdsale ends, via the foundation's multisig, probably proxying through the continous token sale contract.
from mana.
maraoz
commented on August 30, 2024
i.e: we don't need to enable transfers during the crowdsale event
from mana.
maraoz
commented on August 30, 2024
@federicobond can you implement this?
@eordano comments?
from mana.
maraoz
commented on August 30, 2024
@federicobond @eordano there doesn't seem to be a way to unpause the token with current version
from mana.
federicobond
commented on August 30, 2024
That seems to be the case. We are missing the proxy calls to pause/unpause from the MANAContinuousSale contract which owns the token.
from mana.
maraoz
commented on August 30, 2024
@federicobond token should be paused on token sale contructor, as explained here: #22 (comment)
from mana.
federicobond
commented on August 30, 2024
Fixed in #30
from mana.
nachomazzara
commented on August 30, 2024
🎉 This issue has been resolved in version 1.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from mana.
Related Issues (20)
- Add explicit visibility specifiers to all functions HOT 2
- Use SafeMath in MANACrowdsale.sol Constructor Function HOT 2
- Overflow Analysis TODO Removal HOT 2
- Consider adding comments on OpenZeppelin import versions HOT 1
- processPurchase() && getRate() HOT 2
- burnTokens() public HOT 3
- Broken hard cap for whitelisted investors HOT 1
- Add test cases for Burn and RateChange events HOT 1
- Change token name to "Decentraland Mana" HOT 1
- ContinuousCrowdsale should be called ContinuousSale HOT 1
- Off by one error in rateStepDecrease precondition HOT 1
- Test script exits with success status code even when tests fail HOT 1
- Add proper license HOT 2
- npm test not successful... HOT 4
- why DecentralandCrowdsale is no longer used?
- Fix failing whitelist-related test cases HOT 2
- Improve test coverage of ContinuousCrowdsale bucket logic HOT 2
- Add Natural Specification comments HOT 1
- Split main crowdsale from continuous sale contract HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mana.