Giter Club home page Giter Club logo

Comments (6)

deanishe avatar deanishe commented on July 28, 2024

I guess the Travis configuration is wrong. It is supposed to include 2.6.

It should be straightforward enough to ensure 2.6 support.

However, although AW doesn't absolutely depend on anything that wasn't in Python 2.6, it does depend on features that weren't present pre-10.8.

The main problem is #27. The security CLI program AW uses to store Keychain passwords doesn't work pre-10.8. It might be possible to work around this, but I don't have anything older than Yosemite to test it on. I'm fairly certain this is the only issue.

Is it worthwhile ensuring 2.6 support if AW isn't fully functional on 10.6/7?

from alfred-workflow.

deanishe avatar deanishe commented on July 28, 2024

I've run the test suite with 2.6, and these are the bits that don't work in 2.6 so far:

  • background.py
    • new style formatting
  • update.py
    • argparse not available
  • test_web.py
    • assertIsNone not available
    • new style formatting
  • test_workflow.py
    • assertIsNone not available
    • assertRaises not a context manager
  • workflow.py
    • security -w not available on OS X < 10.8

from alfred-workflow.

m1keil avatar m1keil commented on July 28, 2024

Well, unless you have usage statistics, it's tricky question to answer.
If you look at stats from Omni Software, they have about 3% usage from OS X 10.7. So lets say Alfredapp have about the same distribution of users and 100000 active installations... So we are talking about 4k potential users. Out of these how many actually use custom workflows? Lets say 50% and out of these let's say 50% use AW workflows? So this affects about 1% percent? Is it important to you or not? :-) (obviously it's just a very rough guess which might be total BS, since usage of OS X 10.6 is actually higher than 10.7 in other reports I saw)

If making the changes to fix the issues above is not too hard, I would vote yes. The only real bummer is the argparse part. My workflow actually brings argparse with it to try and support 2.6.

from alfred-workflow.

deanishe avatar deanishe commented on July 28, 2024

I'm already going through the code. The changes are all pretty simple. The unit tests are by far the hardest part. argparse isn't a big deal, as the usage is totally trivial. It can easily be replaced with optparse or pure sys.argv.

As mentioned above, my main concern is that the Keychain access won't work pre-10.8, so some workflows will run on older installs and others won't.

At any rate, I've found a library that can parse the output of security find-generic-password -g …, so it should be possible to get that working on older versions of OS X, too.

from alfred-workflow.

deanishe avatar deanishe commented on July 28, 2024

Should all be fixed in 0551765.

from alfred-workflow.

m1keil avatar m1keil commented on July 28, 2024

👍 great!

from alfred-workflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.