Compatibility of the library with OS X 10.7.5 about alfred-workflow HOT 5 CLOSED

Thanks for reporting the problem. Unfortunately, it's not a simple one to fix.

I just replaced -w by the -g option in workflow.py
This makes the error disappear.
However, the workflow isn't still working (although it works the first time, it crashes later on), as other authentication errors show up. It is close to work though.

It makes that error disappear, but it causes the other authentication errors. I'm afraid it's not actually close to working :(

Replacing -w with -g doesn't work because they do different things. -w, where available, outputs only the password, whereas -g outputs the entire entry for the Keychain item in some odd format:

$ security add-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key3 -w 'This is a test'

$ security find-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key3 -w
This is a test

$ security find-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key3 -g
keychain: "/Volumes/Users/daj/Library/Keychains/login.keychain"
class: "genp"
attributes:
    0x00000007 <blob>="net.deanishe.alfred-pinboard"
    0x00000008 <blob>=<NULL>
    "acct"<blob>="pinboard_api_key3"
    "cdat"<timedate>=0x32303134303832343130353033345A00  "20140824105034Z\000"
    "crtr"<uint32>=<NULL>
    "cusi"<sint32>=<NULL>
    "desc"<blob>=<NULL>
    "gena"<blob>=<NULL>
    "icmt"<blob>=<NULL>
    "invi"<sint32>=<NULL>
    "mdat"<timedate>=0x32303134303832343130353033345A00  "20140824105034Z\000"
    "nega"<sint32>=<NULL>
    "prot"<blob>=<NULL>
    "scrp"<sint32>=<NULL>
    "svce"<blob>="net.deanishe.alfred-pinboard"
    "type"<uint32>=<NULL>
password: "This is a test"

So the output from -g requires parsing. Things also get a lot more complicated if there is a backslash or non-ASCII character in your password:

$ security add-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key2 -w 'This " is a \test"'

$ security find-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key2 -w
This " is a \test"

$ security find-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key2 -g
keychain: "/Volumes/Users/daj/Library/Keychains/login.keychain"
class: "genp"
…
…
password: 0x5468697320222069732061205C7465737422  "This " is a \134test""

$ security add-generic-password -s net.deanishe.alfred-pinboard -a pinboard_api_key2 -w 'This is a tüst'
keychain: "/Volumes/Users/daj/Library/Keychains/login.keychain"
class: "genp"
…
…
password: 0x5468697320697320612074C3BC7374  "This is a t\303\274st"

Notice that using -g in this case returns a different format with \xxx escapes in the output.

So it would be a lot more complicated to use the -g option instead of -w. There is another way to access Keychain using the Python–Objective-C bridge, but that doesn't help with the second problem:

I don't have a Lion machine to test it on: there might be other problems, too.

I'd be happy to accept a pull request implementing the change, but it's not one I can realistically do myself because I don't have anything older than Mavericks to test it on, and I don't want to spend hours re-implementing a feature for it to turn out to be still broken, just in a different way.

from alfred-workflow.

Thanks a lot for the detailed and clear explanations. Now I understands precisely why it didn't work and it seems daunting :). If I get the time, I will try to solve the problem on my local fork.

from alfred-workflow.

I'm closing this issue for now, but please feel free to reopen it if you come up with an idea of how to fix the problem: it's something I would like to work.

from alfred-workflow.

Should work in 0551765

from alfred-workflow.

Awesome job @deanishe, thanks a lot. It fixed the whole issue. I was able to test it on Lion with the above-mentioned alfred-workflow and now it makes it at least compatible with 10.7 and, I guess, 10.6 as well. Will likely make many others workflows work on 10.6 and above. Sweet !

from alfred-workflow.