Problems with newlines about php-quill-renderer HOT 8 CLOSED

Its seems like the empty

{
      "insert": "\n"
    },

Is not parsed / rendered. Like it would skip the content.

here is also the rendered html content:

original:

<h1>Hallo</h1>
<p><br></p>
<p>Das ist ein normaler Text:</p>
<p><br></p>
<p><strong>Test: Eintrag</strong></p>
<p><strong>Test: Zwei</strong></p>
<p><br></p>
<p>https://heartbeat.gmbh</p>
<p><br></p>
<p><br></p> 

rendered trough delta:

<h1>Hallo</h1><br />
<p>Das ist ein normaler Text:</p><br />
<p><strong>Test: Eintrag</strong><strong>Test: Zwei</strong></p><br />
<p>https://heartbeat.gmbh</p><br />
<p></p><br />

from php-quill-renderer.

@nadar Thank you for the bug report.

There appear to be two issues here, one, empty inserts should be rendered, two, your example is producing
tags outside block elements, that shouldn't happen. I'll look at both issues tomorrow and try to get a fix out as soon as possible, probably be done as two fixes, the first is quicker to test and fix.

I think by default, my library ignores empty inserts but really it should produce the requested HTML, I will switch the current behaviour to an option and default to rendering everything requested.

from php-quill-renderer.

If there is something i can help, let me know.

from php-quill-renderer.

@nadar This is should be fixed in v3.14.2, newline only inserts are no longer ignored. I added a test using your delta above, DBlackborough\Quill\Tests\Api\BugTest::testNewlineOnlyInsertsIgnored().

Testing using your delta I didn't get the second issue I mentioned, so, for now, I am going to assume this issue is closed.

Again, thank you for the bug report.

from php-quill-renderer.

This issue is fixed. Thanks. But now if have another issue when using multiple newlines like this:

{
      "insert": "\nTest:\n\n"
},

it generates <p>Test</p>
but should indeed also add an empty <p> or <br> element like the original editor html markup does. (ugly - but it looks like the user inputs the data):

So it should generate

<p>Test</p>
<p><br /></p>

or maybe at least <p>Test<br /></p>

from php-quill-renderer.

@nadar I'll have another look at this, cheers again.

from php-quill-renderer.

Closing for now, no follow-on issues have been raised relating to new lines. A newline issue was fixed in v3.14.3 which is after I reopened this ticket so until additional issues are found I'm going to assume this is working as I intended. :)

from php-quill-renderer.

I think the issue above still persist, but its maybe also how you are handling the html output, if you like to have the same output as quill html generates it would be wrong. I assume the summary i made here nadar/quill-delta-parser#3 (comment) is very clear about this.

Closing the issue is fine i guess :-)

from php-quill-renderer.