Giter Club home page Giter Club logo

Comments (5)

ZimGil avatar ZimGil commented on May 26, 2024 1

I agree that the best practice should be to add generated file to .eslintignore
Yet I think that it could be nice to have it.

Of course it should be an option and we should not force anything.

As for the default value:
IMHO - most cases would not want to lint generated files.
On the other hand defaulting to true would be a breaking change :) so I vote on adding an option with a false as default.

from wsdl-tsclient.

pfumagalli avatar pfumagalli commented on May 26, 2024

We just use an .eslintignore file containing the directory of the generated types...

https://eslint.org/docs/user-guide/configuring/ignoring-code

from wsdl-tsclient.

ZimGil avatar ZimGil commented on May 26, 2024

Same here - and yet it could be helpful in some cases.

For example, ts-proto does the same

from wsdl-tsclient.

dderevjanik avatar dderevjanik commented on May 26, 2024

@pfumagalli @ZimGil Do you think it could be good idea to add an option for this? Or make it default similar to openapi-generator....

from wsdl-tsclient.

dderevjanik avatar dderevjanik commented on May 26, 2024

I did small research regarding /* eslint-disable*/ in other projects like openapi-generator and it seems that some people don't care too much about linting their code and some do.

check this comment OpenAPITools/openapi-generator#802 (comment) by @bodograumann . I think he has the point. Adding path of your generated client to .eslintignore is very easy.

What do you think?

from wsdl-tsclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.