Giter Club home page Giter Club logo

Comments (5)

 avatar commented on July 21, 2024

@pilloPl What do you propose?

from library.

bslota avatar bslota commented on July 21, 2024

The reason for this issue to be opened is a confusion we faced at some point. Let me describe it. It was hard for me to distinguish notions of collect, checkout and return. It turned out to mess our discussions, so we finally found some sources that clearly state, that in the context of book lending, libraries, the checkout is actually equal to collect (go to the library, take the book, go home), not to return as one (including me) could think. Regarding the code, checkout is used properly, but I believe we should get rid of the collect part both from model and from code, replacing any occurrence with word checkout. @pilloPl please correct me if I'm wrong

from library.

 avatar commented on July 21, 2024

@bslota Okay, so if @pilloPl approves, I will be working on this.

from library.

 avatar commented on July 21, 2024

@bslota @pilloPl Here is the PR #27 for required changes.

All integration & unit tests are passing.

from library.

 avatar commented on July 21, 2024

@bslota @pilloPl Conflicts are resolved and PR is updated. Please review.

from library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.