Giter Club home page Giter Club logo

Comments (4)

dckiller51 avatar dckiller51 commented on June 30, 2024

Hello ,
I don't have a problem with the changes but it must be compatible with the card that goes with it https://github.com/dckiller51/lovelace-body-miscale-card.

For the configuration options min_weight, max_weight, min_impedance, max_impedance it allows to have a quick state.
https://community-assets.home-assistant.io/original/3X/a/c/ac505f58d1c54e97f02f633ae2b379ff9c7d66ef.png

from bodymiscale.

edenhaus avatar edenhaus commented on June 30, 2024

I don't have a problem with the changes but it must be compatible with the card that goes with it https://github.com/dckiller51/lovelace-body-miscale-card.

That's of course, I use also this card :) The entity stays at it is only new will be added.

For the configuration options min_weight, max_weight, min_impedance, max_impedance it allows to have a quick state.
https://community-assets.home-assistant.io/original/3X/a/c/ac505f58d1c54e97f02f633ae2b379ff9c7d66ef.png

Sorry I didn't understand it. I understand, that when they impedance is negative it is not a valid value and therefore still a "impedance low" error state will be created. I would only delete the ability for the user to change this values and internal use the default values as specified in const.py

DEFAULT_MIN_WEIGHT = 10
DEFAULT_MAX_WEIGHT = 200
DEFAULT_MIN_IMPEDANCE = 0
DEFAULT_MAX_IMPEDANCE = 3000

from bodymiscale.

dckiller51 avatar dckiller51 commented on June 30, 2024

Ok I thought you wanted to delete it. we can actually put it in hard.

from bodymiscale.

edenhaus avatar edenhaus commented on June 30, 2024

I don't have a problem with the changes but it must be compatible with the card that goes with it https://github.com/dckiller51/lovelace-body-miscale-card.

We probably need also adjust the card in the future as HA development guidelines are saying the following:
grafik
https://developers.home-assistant.io/docs/core/entity#generic-properties

So probably after I have created a sensor for each attribute, we should adapt the card to use the new sensors and afterwards remove the old bodymiscale entity completely.

We don't have to hurry, but we should keep it on the radar.

from bodymiscale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.