Giter Club home page Giter Club logo

Comments (9)

mattkoch614 avatar mattkoch614 commented on June 1, 2024 1

@dcarbone All set - I updated my version to 0.5.1 and re-generated my classes. I then ran through the same scenario I originally reported and the double quote issue is now gone.

Thanks for the help!

from php-fhir.

leonrenkema avatar leonrenkema commented on June 1, 2024

When I try to run your code in Laravel I see the following {"id":"1234","resourceType":"Observation","issued":"2018-02-09T22:35:33+01:00"} but I'm using pregenerated files from a fork (https://github.com/leonrenkema/php-fhir-generated/tree/develop) there is a little bugfix in there which is not fixed in the main library.

Maybe you can test that to see if the problem still exists then?

from php-fhir.

mattkoch614 avatar mattkoch614 commented on June 1, 2024

Happy to give this a shot when I'm able. Any idea what the bug fix is? Seems like a good opportunity to open a PR here.

from php-fhir.

leonrenkema avatar leonrenkema commented on June 1, 2024

It is a temporary solution for issue #28 but that should not explain the problem you are describing.

What happens when you serialize it to XML?

edit: Isnt this the same as issue #25? That should be resolved in the master branch it guess.

from php-fhir.

dcarbone avatar dcarbone commented on June 1, 2024

Yes, it is resolved in master. I will create a bugfix version of 0.5 for those who are using a "stable" release.

I really should release 0.6 soon, i think lol...

from php-fhir.

dcarbone avatar dcarbone commented on June 1, 2024

@mattkoch614 sorry for that bug, I have created release 0.5.1 that addresses this issue. Using your example and the updated output, I got this:

{"id":"1234","resourceType":"Observation","issued":"2018-02-10T16:54:59-0600"}

Let me know if you find anything else!

from php-fhir.

dcarbone avatar dcarbone commented on June 1, 2024

oop, let me know if I can close this!

from php-fhir.

mattkoch614 avatar mattkoch614 commented on June 1, 2024

Thanks for the quick response! Once I get a chance to test this I’ll report back.

from php-fhir.

dcarbone avatar dcarbone commented on June 1, 2024

@mattkoch614: any updates on whether I can close this ticket?

from php-fhir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.