[Bug] Duplicate dependency specifications means prod and dev version of protobuf might differ about dbt-core HOT 5 CLOSED

Hi, thank you for opening this issue! We've already merged backports into 1.5.latest and 1.6.latest to fix this 🙂 We're doing patch releases for 1.5 and 1.6 today which will make the fix available via pypi

from dbt-core.

@dbeatty10 & @niteshy I think we should actually re-open this, but slimmed down and re-titled to focus on

Another concern, we should not have duplicate dependencies listed in setup.py and dev-requirements.txt because these manual mistakes can happen again in the future.

The title could be altered to [House Keeping] Remove duplicate protobuf dependency specification in dev-requirements.txt

And the description should be something along the lines of

## Current Behavior
Currently we specify the protobuf dependency in both `setup.py` and `dev-requirements.txt`. This is unnecessary because whenever we install `dev-requirements.txt` we also install the requirements for core which pulls in protobuf from `setup.py`. It's good that when we run `make dev`, core's requirements are pulled in. However, it's bad that we update the protobuf specification in one place and not the other, then the version of protobuf we end up with in tests and production might significantly differ. 

from dbt-core.

I have put the fix for this #9831. This is the first time we are trying to put a fix on the dbt-core.
@QMalcolm can you help me to explain why tests are failing in #9831?

from dbt-core.

Thanks again for your help alerting about this issue and identifying the fix @niteshy 🏆

I'm going to close this issue since it is addressed in the following PRs:

• #9630
• #9708
• #9706
• #9707

from dbt-core.

Additionally @niteshy already has an open PR which takes care of the issue #9838

from dbt-core.