Cors headers are not set when an error is returned from the handler about iron-cors-rs HOT 6 CLOSED

You are right, that is not intended. I'll try to fix it once I find time to do so. PRs are welcome of course!

from iron-cors-rs.

In the CorsHandlerAllowAny impl replacing

        let mut res = try!(self.handler.handle(req));

        // Add Access-Control-Allow-Origin header to response
        res.headers.set(headers::AccessControlAllowOrigin::Value("*".into()));

        Ok(res)

with

        match self.handler.handle(req) {
            Ok(mut res) => {
                res.headers.set(headers::AccessControlAllowOrigin::Any);
                Ok(res)
            }
            Err(mut err) => {
                err.response.headers.set(headers::AccessControlAllowOrigin::Any);
                Err(err)
            }
        }

at least compiles and runs the existing tests successfully but I don't have time to fully test it at the moment.

from iron-cors-rs.

@mdaffin see #5. would you like to test that branch?

from iron-cors-rs.

Thanks. Will have a look at it when I get a moment.

from iron-cors-rs.

@dbrgn I have tested #5 with my application and looks like it has fixed the problem.

from iron-cors-rs.

Version 0.5.1 containing the fix is now on crates.io!

from iron-cors-rs.