Comments (2)
benbotto
commented on July 30, 2024
3
https://github.com/db-migrate/mysql/blob/master/index.js#L375 That function's called from runSql and it's not quite right. It shift the first argument (sql), then pops the last. It blindly expects the last argument to be callback. It should probably check if the last argument is an array and, if so, treat it as params. If I get some time I'll try to fix it and file a PR.
from mysql.
patlillis
commented on July 30, 2024
I am running into this bug as well. This prevents runSql from being used with Promises and async/await, which is a huge pain.
from mysql.
Related Issues (14)
- Add dynamic and virtual columns support
- Support BEFORE and AFTER clauses in createColumnConstraint() HOT 3
- Support for JSON and ENUM data types
- Add showDatabase method
- typeCast config option is getting deleted/ignored
- Add support for precision and scale for decimal type HOT 2
- Cannot add primary key with addColumn
- Ignoring invalid configuration option passed to Connection: driver. HOT 8
- Incorrect charset collate ordering HOT 1
- db-migrate-mysql.connect(): do not pass driver option on to mysql.createConnection() HOT 1
- switchDatabase uses runSql instead of all
- Promise warning thrown HOT 1
- Support for TINYINT and MEDIUMINT HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql.