June review feedback about sidekiq-statistic HOT 11 CLOSED

For (1) would it help to have lib/sidekiq_history which does nothing but require "sidekiq/history"? That's a fairly standard way of tackling gem extension naming so that you don't need to do that Gemfile stunt. I like the name sidekiq-history personally.

from sidekiq-statistic.

There's already a gem by that name. https://rubygems.org/gems/sidekiq-history

from sidekiq-statistic.

Sorry I meant lib/sidekiq_history.rb with the extension.

from sidekiq-statistic.

Ohhh. I see.

from sidekiq-statistic.

Mike, thanks for feedback 😊
About first point: I think I'll rename gem to sidekiq-statistic or something else. I don't like history name because I grab statistic information substantially. What do you think?

from sidekiq-statistic.

1. I don't know about this. It's great tips, thanks 🌟
2. Yes, you're absolutely right. Thanks for the tip

from sidekiq-statistic.

Also I want to remove this initializer from all my classes:

def initialize(days_previous, start_date = nil)
  @start_date = start_date || 
  @end_date = @start_date - days_previous
end

from sidekiq-statistic.

@mperham what do you think about chronikiq? 😄

from sidekiq-statistic.

How's the project going? Any ETA for this issue? That's a clever name but I would be worried if people would remember how to spell it. Ultimately it is your project and you can name it whatever you want.

from sidekiq-statistic.

@mperham I am working on thread-safe middleware now #26. I hope that I will complete this issue by the weekend 😬

from sidekiq-statistic.

@davydovanton great work, thanx!

from sidekiq-statistic.