Live announcements are announced too early if host timezone is ahead about rail-announcements HOT 8 CLOSED

I think this one should be sorted now based on my testing while travelling in Europe this week.

from rail-announcements.

I'm having this issue too. I'm in Canada, on Eastern Standard Time.

What I'm seeing in the logs is that trains that are less than 4 minutes away are being marked as "more than 4 minutes away" since my system clock is 5 hours behind UK time.

This does appear to be a regression, as I was not having this issue previously (I can recall everything working properly about a month ago, but not sure of the exact date when the announcements stopped working.)

I will note that delay/cancellation announcements do work properly, just not the "Platform 1 for the 18:33 service to London Paddington..." announcements.

from rail-announcements.

Yeah, this is going to be because I moved to the staff departures endpoint of my API from the basic one. This has made my life A LOT easier with regards to getting proper date-time data for estimated arrival/departure, as well as separate arrival/departure times and the raw disruption data behind services.

The downside is that those date-time values don't have a timezone attached.

My understanding is that Huxley2 (the JSON-SOAP intermediary for Darwin data that I use) tries to be relatively transparent with the data it passes down, so adding the TZ there wouldn't be a great idea.

My other solution would have been to add it locally into API responses as part of the data parsing/filtering. This is probably better done with something like day.js rather than trying to use native JS APIs.

from rail-announcements.

https://github.com/davwheat/uk-dot-matrix/blob/6f1612f5185ae6b0d0f39b8a944154ad7d1e690a/src/components/displays/NewGTR/TrainServices.tsx#L16-L19

https://github.com/davwheat/uk-dot-matrix/blob/6f1612f5185ae6b0d0f39b8a944154ad7d1e690a/src/components/displays/NewGTR/TrainServices.tsx#L246-L254

This is how I'm trying to prevent this issue in the upcoming changes for my dot matrix board.

from rail-announcements.

I believe this should have been fixed during various changes I've made. Let me know if this happens again!

from rail-announcements.

When I currently visit https://railannouncements.co.uk/amey-live-train-announcements/, trains are still announced up to ~30 minutes ahead. I have tried reloading with CTRL+F5 to clear the cache, but the same behaviour remains.

Based on some local testing, it seems like
dayjs.tz.setDefault("Europe/London");
doesn't change the result of dayjs(s.etd), like in this case on line 1134; It is always interpreted in the local timezone.

This doc page suggests using dayjs.tz(s.etd, "Europe/London")

from rail-announcements.

But the docs do also say that setDefault should work: https://day.js.org/docs/en/timezone/set-default-timezone#docsNav

Do services also disappear off the departure board early too, or just get announced early?

from rail-announcements.

That page seems to talk specifically about the dayjs.tz constructor? So it sets the default for that, but not for dayjs() itself.
The departure board looks to be correct, though I've only looked at it now. I've not tested if it stays accurate when running for a longer time.

from rail-announcements.