[Bug]: AutoScroll position jumps when clicked and dragged about embla-carousel HOT 7 OPEN

Oh yeah, something like watchFocus would be beneficial. Thanks a lot for coming up with a fix. I'll just go with the hacky solution for now but happy to help if you'd need me to test anything.

from embla-carousel.

Thanks @jasonk16. It would definitely help if you wouldn’t mind testing as soon as I have a draft ready. I’ll let you know when I have something 👍🏻.

from embla-carousel.

Hi @jasonk16,

Thanks for your bug report. Have you seen the example in the docs? Can you reproduce it there? If no, please check how to work with the plugin there.

Best,
David

from embla-carousel.

Thanks for your quick reply @davidjerleke. I've reproduced the jumpyness based on the example here, I've just changed the individual items to suit my needs, which is an image container.

from embla-carousel.

@jasonk16 thanks! I'll investigate what's going on when possible.

This might be related to anchor tags being elements that can receive focus. If my assumption is correct, the carousel jumps to the slide that is active when the focus event is triggered from a click.

Best,
David

from embla-carousel.

Your assumption is correct. I've just tried removing the anchor tags from the cards and it does not jump anymore. Perhaps I could use onClick on divs as a workaround temporarily, but long term I guess its not a good html semantics if those cards are links.

I also tried nesting the anchor tag within the div but I guess the focus still triggers on click. Let me know if theres anything you'd need my help on. Thanks again!

from embla-carousel.

Perhaps I could use onClick on divs as a workaround temporarily, but long term I guess it's not a good html semantics if those cards are links.

@jasonk16 you're right about that. It's not good semantics so a solution for this is needed. I'm working on a new option called watchFocus which will enable you to either disable/enable the auto focus feature with a boolean. Alternatively, you will be able to pass your own callback to control when Embla should focus or not: Similar to watchDrag, watchResize and watchSlides.

Unfortunately, until then, you'll have to stick with the hacky solution you mentioned.

Best,
David

from embla-carousel.