Giter Club home page Giter Club logo

Comments (12)

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Do your iFrames have IDs on them?

from iframe-resizer.

porduna avatar porduna commented on July 19, 2024

They didn't. Now they have and I'm using iFrameResize({ ... }, "#outer") with same results.

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Oh the HTML tag, not the JS call.

from iframe-resizer.

porduna avatar porduna commented on July 19, 2024

You mean:

<iframe id="inner" src="inner.html" width="100%" ></iframe>

? Yep, I added that in the last comment and additionally used the "#inner" in the call.

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

What happens in the endless loop? Which browser? Does the nested example work for you?

from iframe-resizer.

porduna avatar porduna commented on July 19, 2024

Google Chrome v35, Firefox 24 and Firefox 29 under Linux.

Sorry, hadn't seen the nested example. Same problem: it works well when opening the top frame and then clicking on the Nested link. But opening the nested frame directly, there is an endless loop where the height is being continuously increased.

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Oh now I understand the issue. Will take a look.

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Does this work for you now?

http://davidjbradshaw.com/iframe-resizer/example/frame.nested.html?1

from iframe-resizer.

porduna avatar porduna commented on July 19, 2024

Both in Firefox and Chrome it does not enter in a loop anymore. In Chrome it works perfectly, but in Firefox the iframe is not properly resized (see screenshot).

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Bugger seems FireFox has a function stack scoping bug in it JS implementation. Can you give it another go.

D.

from iframe-resizer.

porduna avatar porduna commented on July 19, 2024

Thank you! It works like a charm in Chrome, Firefox 24 and 29. Thank you!

from iframe-resizer.

davidjbradshaw avatar davidjbradshaw commented on July 19, 2024

Cool will publish the fix shortly as v2.5.1

from iframe-resizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.