Comments (9)
Cool do you want to send me a pull request with the fix.
from iframe-resizer.
Yes - I can do that later today...
from iframe-resizer.
Thanks, now that I'm back home I'm wondering if it could that be reduced down to.
retVal = document.defaultView.getComputedStyle(el, null);
retVal = (null !== retVal) ? retVal[prop] : 0;
from iframe-resizer.
Yeah - that is probably better. Would you like me to update the pull request?
from iframe-resizer.
Yeah why not.
Also do you fancy writing a qUnit test for this?
from iframe-resizer.
Ok pull request has been updated. I haven't written a qUnit test before... is it easy to learn how?
from iframe-resizer.
Yeah it's pretty straight forward, have a look at the html files in the test folder for some examples, the _init.html is the simplest one.
I think you could strip that back to the first assertion that test it got a message back and the create a new iframe contents html page in the resource folder with a simple version of the page that was creating the problem.
Once you've done that you can just run 'grunt' and it will automagically run the test along with all the other ones.
from iframe-resizer.
Hmm ok I'll look into it...
from iframe-resizer.
Thanks.
from iframe-resizer.
Related Issues (20)
- How to use this in SvelteKit? HOT 2
- wrong files version in js folder for 4.3.6
- Undocumented option `warningTimeout`
- Logo Design
- Feature request: add optional offset argument to moveToAnchor method HOT 4
- Trigger iframe-resizer to resize HOT 1
- How to integrate with nuxt3? HOT 2
- Time overhead when adding many elements under a same HTML element HOT 4
- i am having button inside iframe . how can i detect button click event HOT 1
- Scroll to element on AJAX request not working in child page even with scrolling set to yes HOT 1
- BREAKING🐞: `v4.3.9` release breaks usage of `.min.js` file from CDN HOT 5
- Scrolling may make the page jump to the left HOT 4
- [Feature Request] Add onResizeError callback HOT 4
- Value for minHeight can not be greater than maxHeight HOT 1
- Extra padding in Safari (macOS) 17.3 HOT 11
- Rounding up calculated height value to non-decimal number to prevent scrollbar from showing HOT 33
- Callback from IframeResizer does not get the latest state object HOT 2
- iFrame with dynamic blog posts nested in toggles not resizing in mobile phones. HOT 10
- Svelte HOT 3
- How to handle media queries? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iframe-resizer.