TypeError: document.defaultView.getComputedStyle(...) is null about iframe-resizer HOT 9 CLOSED

Cool do you want to send me a pull request with the fix.

from iframe-resizer.

Yes - I can do that later today...

from iframe-resizer.

Thanks, now that I'm back home I'm wondering if it could that be reduced down to.

retVal = document.defaultView.getComputedStyle(el, null);
retVal = (null !== retVal) ? retVal[prop] : 0;

from iframe-resizer.

Yeah - that is probably better. Would you like me to update the pull request?

from iframe-resizer.

Yeah why not.

Also do you fancy writing a qUnit test for this?

from iframe-resizer.

Ok pull request has been updated. I haven't written a qUnit test before... is it easy to learn how?

from iframe-resizer.

Yeah it's pretty straight forward, have a look at the html files in the test folder for some examples, the _init.html is the simplest one.

I think you could strip that back to the first assertion that test it got a message back and the create a new iframe contents html page in the resource folder with a simple version of the page that was creating the problem.

Once you've done that you can just run 'grunt' and it will automagically run the test along with all the other ones.

from iframe-resizer.

Hmm ok I'll look into it...

from iframe-resizer.

Thanks.

from iframe-resizer.