Giter Club home page Giter Club logo

Comments (3)

MrMineev avatar MrMineev commented on August 22, 2024

The phone number "1 (123) 456 7890" is invalid. The phone US phone numbers have this syntax 1(NXX) NXX-XXXX, where N represents any digit from 2 to 9, and X represents any digit from 0 to 9. (https://www.quora.com/What-is-the-American-mobile-phone-number-format) (https://en.wikipedia.org/wiki/North_American_Numbering_Plan)

from python-phonenumbers.

etekin-amfam avatar etekin-amfam commented on August 22, 2024

The phone number "1 (123) 456 7890" is invalid. The phone US phone numbers have this syntax 1(NXX) NXX-XXXX, where N represents any digit from 2 to 9, and X represents any digit from 0 to 9. (https://www.quora.com/What-is-the-American-mobile-phone-number-format) (https://en.wikipedia.org/wiki/North_American_Numbering_Plan)

That is true, but the code does not raise an Exception, just returns an incorrectly parsed number, so it is still an issue as the downstream code has no way of knowing the number was incorrect. Furthermore, if you do enter +11234567890, it does not complain that it is an invalid number.

from python-phonenumbers.

daviddrysdale avatar daviddrysdale commented on August 22, 2024

The Python code is behaving the same as the upstream Java code here, so any requested/suggested changes to behaviour should be reported upstream.

from python-phonenumbers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.