Task was destroyed but it is pending about goblin HOT 3 CLOSED

Hi @patricknee. What is happening here is that when you return the first message in the loop you are short circuiting the iteration so the response is not properly closed. Normally, the response receives None from the driver, closes the response, and calls StopAsyncIteration. However, you never get there because you just return the first result. There are two ways to avoid this:

1. If you are unsure of the number of results that will be returned in the stream, you can store them in a container until the iteration finishes:

result = []
resp = await conn.submit(gremlin=script, bindings=binding)
async for msg in resp:
    result.append(msg)
return result

2. If you are sure that you are only going to get one result back on the stream you can do this:

resp = await conn.submit(gremlin=script, bindings=binding)
result = await resp.fetch_data()
resp.close()
return result

However, the first approach is preferable to the second because this assures that you read all the returned results from the underlying stream. When Python 3.6 becomes generally available, you will be able to simply yield results as they come in, and this will be the best option of all:

resp = await conn.submit(gremlin=script, bindings=binding)
async for msg in resp:
    yield msg

I hope that helps and thanks for your interest in Goblin. Let me know if you have any more questions.

from goblin.

Yes, I was pretty sure it was the iterable nature of response, and I should have tried handling the result in a list... I tried a few other things (appending strings) before writing. Thanks for the quick response.

from goblin.

No worries. I'm going to go ahead and close this issue.

from goblin.