Giter Club home page Giter Club logo

Comments (3)

andyjefferson avatar andyjefferson commented on July 20, 2024

All issues need testcases so that they are reproducible. The only exception to that is where people are going to develop fixes themselves, that don't break other features

from datanucleus-ldap.

rezarahimi avatar rezarahimi commented on July 20, 2024

I have commented it with following patch for my self because I care my self that do not use IdentityType.DATASTORE for my PersistenceCapable LDAP classes:

--- a/src/main/java/org/datanucleus/store/ldap/LDAPMetaDataListener.java
+++ b/src/main/java/org/datanucleus/store/ldap/LDAPMetaDataListener.java
@@ -33,10 +33,10 @@ public class LDAPMetaDataListener implements MetaDataListener
      */
     public void loaded(AbstractClassMetaData cmd)
     {
-        if (cmd.getIdentityType() == IdentityType.DATASTORE && !cmd.isEmbeddedOnly())
+ /*       if (cmd.getIdentityType() == IdentityType.DATASTORE && !cmd.isEmbeddedOnly())
         {
             // Datastore id not supported
             throw new InvalidClassMetaDataException("LDAP.DatastoreID", cmd.getFullClassName());
-        }
+        }*/
     }

and my test environment is inside Apache ISIS and I don't know when I can create a suitable separate test case for it(I will try to do it but I am not sure when) but it is clear that checking all the AbstractClassMetaData classes with identityType of IdentityType.DATASTORE without any guards includes all classes of all stores and the RDBMS ones too.
I had to fix some other bugs in datanucleus-core and datanucleus-rdbms too for running my Apache ISIS application which need really a test case.

from datanucleus-ldap.

andyjefferson avatar andyjefferson commented on July 20, 2024

Thanks, but clearly commenting out functionality is not an option.
What would be an option is for you to provide a persistence property that is applied at the store level (StoreManager) that disables metadata checks (default to have them enabled). So then you can disable via a persistence property for particular stores used by DataFederation.

from datanucleus-ldap.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.