Consider relaxing NodeId: Default bound about openraft HOT 4 OPEN

Glad to hear that the workaround is functioning well for you.
If there's ever an opportunity to refactor, I will definitely keep your suggestion in mind.

Thank you for raising this issue.

from openraft.

👋 Thanks for opening this issue!

Get help or engage by:

• /help : to print help messages.
• /assignme : to assign this issue to you.

from openraft.

I'm afraid removing NodeId: Default from the current codebase may not be straightforward. Types like LeaderId need to offer a zero value for uninitialized states or testing purposes. Utilizing Option would introduce unnecessary error handling using unwrap().

For your specific scenario, a potential and straightforward solution is to encapsulate libp2p::PeerId within another struct that implements Default:

struct P2PNodeId(libp2p::PeerId);
impl Default for P2PNodeId {
  fn default() -> Self { /* ... */ }
}

from openraft.

Yes, that's exactly how we're handing it now, it works fine, aside from some additional boilerplate of converting the types back and forth.

If there's ever going to be a refactoring/redesign of how you handle LeaderId internally, please, consider this issue.

from openraft.