Describe the bug When you modify the example network implementati

👋 Thanks for opening this issue! Get help or engage by: <ul dir

replication deadlocks after Unreachable error from the Network about openraft HOT 6 CLOSED

pepinns commented on September 24, 2024

replication deadlocks after Unreachable error from the Network

from openraft.

Comments (6)

github-actions commented on September 24, 2024

👋 Thanks for opening this issue!

Get help or engage by:

/help : to print help messages.
/assignme : to assign this issue to you.

from openraft.

drmingdrmer commented on September 24, 2024

Thank you for reporting this issue in detail and proposing a fix.

What's the version of openraft were you using? I'll check if the issue has been resolved in the main branch.

With the latest main branch, if there is a pending action, drain_events will return immediately:

openraft/openraft/src/replication/mod.rs

Lines 508 to 518 in 5da9594

 pub async fn drain_events(&mut self) -> Result<(), ReplicationClosed> { 

 tracing::debug!("drain_events"); 

 // If there is next action to run, do not block waiting for events, 

 // instead, just try the best to drain all events. 

 if self.next_action.is_none() { 

 let event = self.rx_repl.recv().await.ok_or(ReplicationClosed {})?; 

 self.process_event(event); 

 } 

 self.try_drain_events().await?;

And RaftCore will periodically send an heartbeat event to ReplicationCore to wake up it thus self.rx_repl.recv() should not block for ever.

from openraft.

drmingdrmer commented on September 24, 2024

I was unable to reproduce the issue with a test case. Could you assist me in confirming that the steps in this test align with the steps in your situation:

#834

And with export RUST_LOG=debug, the testing script will output debug level logs, which may help on tracing this issue.

from openraft.

pepinns commented on September 24, 2024

I was on a previous version of main. I'll try again with this updated code and see if this resolves it. My version definitely doesn't have that if statement.

from openraft.

pepinns commented on September 24, 2024

The updated main branch resolves this issue.

from openraft.

drmingdrmer commented on September 24, 2024

I was on a previous version of main. I'll try again with this updated code and see if this resolves it. My version definitely doesn't have that if statement.

Right. I found this bug and fixed it after pushing the backoff to github. :(

from openraft.

Recommend Projects

replication deadlocks after Unreachable error from the Network about openraft HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub async fn drain_events(&mut self) -> Result<(), ReplicationClosed> {
	tracing::debug!("drain_events");

	// If there is next action to run, do not block waiting for events,
	// instead, just try the best to drain all events.
	if self.next_action.is_none() {
	let event = self.rx_repl.recv().await.ok_or(ReplicationClosed {})?;
	self.process_event(event);
	}

	self.try_drain_events().await?;