RaftStorage::get_initial_state should not try to fill in any default values. Leave them None and let the caller to init them. about openraft HOT 6 CLOSED

/assignme

from openraft.

👋 Thanks for opening this issue!

Get help or engage by:

• /help : to print help messages.
• /assignme : to assign this issue to you.

from openraft.

currently, get_initial_state will call InitialState::new_initial to initialize if node is first startup.
i assumed that your wants remove InitialState::new_initial and let the user actively call, right?

from openraft.

No, I do not want users to call InitialState:: new_initial() at all.

• InitialState::new_initial does nothing else than build a default value of InitialState.
  There is nothing a user has to impl for InitialState.
  Thus just let Raft do this job. A user just returns None.

• In addition, what get_initial_state does is determined. A user does not need to customize get_initial_state if he has already implemented other methods in RaftStorage. Thus get_initial_state can be removed.

from openraft.

Gotcha, What else needs to be done on this issue？

from openraft.

🤔 Just let get_initial_state returns None if the store is uninitialized, along with tests and doc comments updated.

from openraft.