Killing the leader of a cluster generates excessive network attempts for replicating log entries about openraft HOT 4 CLOSED

I can not download the log file you attached, which gave me a 404 error. :(

But I guess what happened with your application is this problem:
https://docs.rs/openraft/0.9.1/openraft/docs/faq/index.html#how-to-minimize-error-logging-when-a-follower-is-offline

How to minimize error logging when a follower is offline?

Excessive error logging, like ERROR openraft::replication: 248: RPCError err=NetworkError: ..., occurs when a follower node becomes unresponsive. To alleviate this, implement a mechanism within RaftNetwork that returns a Unreachable error instead of a NetworkError when immediate replication retries to the affected node are not advised.

from openraft.

👋 Thanks for opening this issue!

Get help or engage by:

• /help : to print help messages.
• /assignme : to assign this issue to you.

from openraft.

Hey @drmingdrmer, thanks for looking into this and sending over that link. That is what seems to be happening. After updating the raft_network_impl.rs file to check if it was a connection related error and return Unreachable instead it behaves as expected.

        let resp = client
            .post(url)
            .json(&req)
            .send()
            .await
            .map_err(|e| {
                if e.is_connect() {
                    return openraft::error::RPCError::Unreachable(Unreachable::new(&e));
                }
                openraft::error::RPCError::Network(NetworkError::new(&e))
            })?;

Any concerns if I add this change to the example in the repo along w/ a comment on why? I feel it may add benefit to others if they encounter the same issue.

from openraft.

Any concerns if I add this change to the example in the repo along w/ a comment on why? I feel it may add benefit to others if they encounter the same issue.

Absolutely, let's polish it up!

It gonna be an excellent job sharpening the example to fit perfectly into this case!

from openraft.