Giter Club home page Giter Club logo

Comments (2)

labbati avatar labbati commented on May 14, 2024

Hi @Lavoaster sorry to hear of the problem and thanks for taking the time to open this pull request.

From my own debugging I can see that we rely on 5.3.* of the elasticsearch/elasticsearch package, however, the composer.json file in here suggests that you rely on the 1.2.* version. (over 4 years old)

We have plans to support recent versions of ES.

It appears that the method you want to hook into doesn't exist in later version of the package. I'm not entirely sure, otherwise I'd send in a PR, but I feel like you're looking for this method https://github.com/elastic/elasticsearch-php/blob/master/src/Elasticsearch/Transport.php#L93.
If possible as well can you put instrumentation setup through try/catches and disable those that fail, possibly with an error somewhere?

The main point here is that we should properly support version 5.x and before that we have to provide a way to test multiple versions of the same library. You can follow this issue #185 as @inverse proposed a very good approach in my opinion.

I've had to disable the elastic search integration provider due to issue.

Just to make sure you did not have to change any code: you can do this by DD_INTEGRATIONS_DISABLED=elasticsearch.

from dd-trace-php.

labbati avatar labbati commented on May 14, 2024

Hi @LavaToaster, we completely rearchitected our API and such issues, like class/method not found cannot happen anymore by design. What we call 'sandboxed' instrumentation. I am closing this issue. Please feel free to comment if this does not hold true for your case and I will reopen it.

from dd-trace-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.