Giter Club home page Giter Club logo

Comments (3)

darccio avatar darccio commented on August 14, 2024

@rarguelloF @zarirhamza Can you review this? Thanks!

from dd-trace-go.

rarguelloF avatar rarguelloF commented on August 14, 2024

@ewhauser Sorry for the delayed response.

From the screenshot you are sending, it seems the postgres.db service disappeared, which is something expected as the pgx.v5 integration by default inherits the service name from DD_SERVICE instead of setting a custom one. We are aware this is an inconsistent behavior between different instrumentations, but overall the preferred behavior from now on is to get rid of these "fake" services (like postgres.db) and instead using DD_SERVICE everywhere in the same service. The DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED environment variable ensures this behavior is applied in every integration/instrumentation you are using.

If you want to have the old behavior (having your pgx.v5 spans with a different service name), you can do the following:

import (
	pgxtrace "gopkg.in/DataDog/dd-trace-go.v1/contrib/jackc/pgx.v5"
)

// ...

db, err := pgxtrace.Connect(ctx, dbUrl, pgxtrace.WithServiceName("postgres.db"))

from dd-trace-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.