opentracing: config and DefaultTracer about dd-trace-go HOT 9 CLOSED

Same issue fore the "enabled" config.
It's not copied properly.

from dd-trace-go.

I can see how this can be confusing. The integrations (contrib/*) are not yet migrated over to use OpenTracing. We are planning to do this for 0.7.0, which will be all OpenTracing compatible. Until then, please hold tight 😊

from dd-trace-go.

OK I understand, thanks.

from dd-trace-go.

The integrations (contrib/*) are not yet migrated over to use OpenTracing

Indeed it doesn't work currently.
In my code, I do this:

• create a root span with the gorilla/mux integration
• create new child span from request's context with open tracing

The result:

• in https://app.datadoghq.com/apm/services I only see the spans created by gorilla/mux, and the child span are not there
• in https://app.datadoghq.com/apm/search I see all span (gorilla/mux + child)

If I understand correctly, the issue is that the span types are not compatible, and the parent span is not found from context (different key probably).

I see several solutions for me:

• wait for the integration migration (when will it be available ?)
• build my own integration compatible with opentracing
• contribute to the existing integration (it should be very similar to my own code)

I'd like to contribute, but I don't know what are your plans.

from dd-trace-go.

PS: if I use only the opentracing span as root, there is no issue.

from dd-trace-go.

wait for the integration migration (when will it be available ?)

I am working on this as we speak and is my main priority at the moment. We plan to release this with 0.7.0 once we dog food it internally. You are welcome to help with that if you want, at your own risk :-)

contribute to the existing integration (it should be very similar to my own code)

I would not advise to do this now, as it will result in terrible merge conflicts.

I'd like to contribute, but I don't know what are your plans.

I would be very happy to have you as a contributor. I think that after we finish this piece of work, contributing to this library should be much easier and straight-forward. I am also glad to hear that you have this intention, your help would be most welcomed.

The best thing you can do for now is to be patient and give us the time to do this. I reckon in a couple of weeks it will be ready. If this is urgent for you, of course you can build your own integration in the mean time. Contributing now is not a very good time because this switch affects the entire codebase.

I am happy to answer any more questions you might have. You are also welcome to reach me on our public Slack if you want.

from dd-trace-go.

quick and dirty hack https://gist.github.com/pierrre/d6f86351ce384a30b548c8ef2ecb6ebf

from dd-trace-go.

@pierrre I will close this as a duplicate of #175 - I hope you don't mind. If that issue doesn't cover it or if this is for something else, then please feel free to re-open.

from dd-trace-go.

ok, no problem

from dd-trace-go.