Giter Club home page Giter Club logo

Comments (5)

ptnapoleon avatar ptnapoleon commented on May 30, 2024 1

there was a particular reason behind the implementation

Not especially, it was just extra work at the time, and we didn't have a need for it. I think we're willing to change it

from chaos-controller.

nikos912000 avatar nikos912000 commented on May 30, 2024

That would be very useful. We are integrating with Kubefed and Spinnaker and this unfortunately causes a lot of issues :(

I hope it makes sense from a design point of view - this is how most controllers define the status afaik.

From a quick look, the following changes are needed:

  • This is the only place where the controller itself updates the status.
  • The webhooks patch the object, so these calls need to be updated.
  • And then the CRD plus the addition of the kubebuilder annotation.

PS: Thanks for being super fast with any issues!

from chaos-controller.

ptnapoleon avatar ptnapoleon commented on May 30, 2024

Closed by #520 , hopefully? We will cut a release this week

from chaos-controller.

nikos912000 avatar nikos912000 commented on May 30, 2024

Amazing, thank you @ptnapoleon!

from chaos-controller.

expFlower avatar expFlower commented on May 30, 2024

Amazing, thanks for the collaboration on this @ptnapoleon

from chaos-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.