Removing factors about r-intro-geospatial HOT 3 CLOSED

Hey @datacarpentry/curriculum-advisors-geospatial , here's an item I think we should talk about for our next meeting. This would be a pretty sizable change, but it's been ~3 years since R4.0 deprecated stringsAsFactors, and the option is going to be removed entirely in R 4.3 (https://cran.r-project.org/doc/manuals/r-devel/NEWS.html).

from r-intro-geospatial.

Good morning.

I would like to provide some context to this issue. I only found 6 references to 'stringsAsFactors' in this leson.

The first two are in the script ./renv/activate.R lines 299 and 561. I'm not an user of the renv package, but I think we can safely remove those as they are set to FALSE (R's default since v4). Besides, the readers aren't supposed to read this script.

The next one is in ./episodes/03-data-structures-part1.Rmd line 412 and it's part of the solution to challenge 3. It makes no difference because it's also set to FALSE. However, that challenge description makes sense from the perspective of R v3. I guess we could update or remove challenge 3.

The next 3 appear in ./episodes/04-data-structures-part2.Rmd lines 73, 348, and 369.

In line 73, stringAsFactors is set to TRUE and it includes a comment explainign the readers the default value of this property changed from R v3 to R v4. Besides, this line sets up data which is needed by a different task below. This was made so to ensure the code runs on R v4 while minimizing the changes to this lesson's contents. This is the change that would require more attention.

In lines 348 and 369 stringsAsFactors is set to FALSE and they can be safely removed.

Bests,

from r-intro-geospatial.

Sounds good to me!

from r-intro-geospatial.