Comments (3)
I appreciate the civility of, "I'm not sure if it's a typo". 😁 It most certainly is a typo, and thank you for catching it.
Since you are comfortable with go, did you try running it with that changed and see if it resolves your issue? Obviously will open a PR to fix that, but it would be good to understand if that alone is your issue, or something else.
from mysql-backup.
I wondered why the integration tests didn't catch it. I just realized why. The integration tests do not run the actual command-line executable. Instead they call the library that is called from the CLI, setting the parameters explicitly. It is much more difficult to write and manage tests without that.
There is a separate set (within the unit tests) that check if parameters get passed properly to those library calls, but that specifically parameter is not exercised. We shall fix that.
from mysql-backup.
Hi, I've been running the docker images so haven't actually needed the go build chain just yet. I'm happy to make a PR with that change.
There is another issue where AWS_ENDPOINT_URL doesn't seem to be respected if in an ENV var vs passed as --aws-endpoint-url, but I didn't want to muddy the issue. Could that be a similar omission in config handling?
Edit: and thank you for the super quick reply!
from mysql-backup.
Related Issues (20)
- Documentation inconsistencies HOT 2
- How to create a backup copy of not only data and tables, but also functions and procedures? HOT 1
- golang mysql-backup missing bzip2 support
- golang mysql-backup does not implement the nice argument HOT 4
- S3 upload issue for newer versions 1.0.0-rc+ HOT 3
- DB_PORT by default is 0 in the newest versions like 1.0.0-rc HOT 1
- How to set DB_DUMP_FILENAME_PATTERN HOT 1
- MariaDB Compatability issue HOT 12
- How to ignore tables? in 1.0.4rc? HOT 3
- Retention settings do not work HOT 2
- Retention again :-( HOT 1
- Dump: bigint type issue HOT 12
- RUN_ONCE only works with setting DB_DUMP{FREQ,BEGIN} to null/nothing HOT 3
- Pruning does not work when safechars is enabled
- tgz file not extractable HOT 4
- Dump: JSON type issue HOT 2
- Simple script for moving to target backup by year and month HOT 6
- Error when using S3 compatible storage endpoint (Cloudflare's R2) HOT 9
- [question] script after S3 upload HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql-backup.