Giter Club home page Giter Club logo

Comments (3)

TomAugspurger avatar TomAugspurger commented on May 27, 2024

Hmm, we'll have to think a bit more about this. It can involve some checks that might be expensive to do, e.g. length checking on a dask.dataframe.

See #72 for some of the edge cases it caught though.

from dask-ml.

PeterDSteinberg avatar PeterDSteinberg commented on May 27, 2024

Is the expensive part that length checking a dask.dataframe requires .compute()? If there are some parts of the check_estimator logic we have to skip, let's at least keep the checks for get_params() and set_params() as methods.

from dask-ml.

TomAugspurger avatar TomAugspurger commented on May 27, 2024

Yeah things like len can be expensive for dask.DataFrames. Other examples would be checking for NaNs / infs: https://github.com/dask/dask-ml/pull/72/files#diff-1be11e310bf210381f8dd957dbc27074R173. Everything else we can do with just the metadata on the dask collection itself.

Though perhaps I'm being overly paranoid about the costs here. Either way, we will want to inform users about which algorithms make multiple passes over the data (like KMeans), so that they'll want to .persist the data before running .fit.

from dask-ml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.