[breaking change] Change the context for the operand of `throw` to `Object`. about sdk HOT 10 CLOSED

Curious, does throw null become a static error?

It already is:

throw null;

produces:

The type 'Null' of the thrown expression must be assignable to 'Object'.

from sdk.

Summary: This change updates the type inference context for throw operands from the unknown type (_) to Object. This aligns the context with the compiler's requirement that throw operands be assignable to Object, improving consistency in type inference.

from sdk.

@vsmenon @leonsenft @Hixie for breaking change review.

from sdk.

LGTM

from sdk.

Curious, does throw null become a static error?

from sdk.

Interesting. :-)

Is that Object not already coming from the context?

Anyway, lgtm on the change.

from sdk.

Yeah, when we implemented null safety we added the requirement that anything being thrown must be assignable to Object (i.e. non-nullable). It would have made sense to change the context to Object at the same time, but we didn't think to do so. (Usually the context matches what type the expression has to be in order to avoid a compile-time error, but there are exceptions, so the implementation has to keep contexts and static error checking separate. As a result, if we don't think to update the context when we add an error condition, it doesn't happen automatically.)

from sdk.

@Hixie ping

from sdk.

Marking this breaking change as approved. @Hixie if you object, please speak up.

from sdk.

Sorry for missing this. This seems like a good change.

from sdk.