Comments (15)
sigmundch
commented on June 29, 2024
1
Thanks everyone! Following the protocol, I went ahead and marked this breaking change as approved
@itsjustkevin - when you are back, is there anything else do to for this issue or is it OK to close it now?
@srujzs - we should be OK to move forward now ahead of the upcoming cutoff next week
from sdk.
srujzs
commented on June 29, 2024
@itsjustkevin I sent out an email to [email protected] for this. Let me know if you need anything else to start the review process. Thanks!
from sdk.
kevmoo
commented on June 29, 2024
LGTM!
from sdk.
sigmundch
commented on June 29, 2024
Thanks @srujzs. Breaking change LGTM too.
cc @mkustermann
from sdk.
mkustermann
commented on June 29, 2024
LGTM
As the API that's being changed is relatively new with limited users, I'd suggest to use an accelerated process to ensure the breaking change will land before the next stable (to minimize change of more users to start relying on the now-deprecated API)
from sdk.
mkustermann
commented on June 29, 2024
@mit-mit @vsmenon The cutoff for next stable seems to be 1st of July. Can we get this approved beforehand to ensure it's included in the next stable? (If we delay this, people may start relying on this API more widely and changing it will cause more trouble for ecosystem, so the sooner we do it the better)
from sdk.
mit-mit
commented on June 29, 2024
LGTM
from sdk.
mit-mit
commented on June 29, 2024
Please make sure to post on dart-announce
from sdk.
sigmundch
commented on June 29, 2024
Thanks, it was posted last week. Usage currently is extremely minimal, so we don't expect to hear much.
from sdk.
mkustermann
commented on June 29, 2024
@itsjustkevin Does it need signoff from anyone else or can this be marked as approved and @srujzs can go ahead and land the change?
from sdk.
sigmundch
commented on June 29, 2024
FYI @itsjustkevin is OOO this week. We believe he will be back next week.
from sdk.
sigmundch
commented on June 29, 2024
Looking at the updated calendar, it seems @itsjustkevin will be OOO until mid week. I reviewed previous breaking change requests and it appears we typically seek approval from representatives in Flutter and ACX as well.
@Hixie @leonsenft @vsmenon - could you take a look at this breaking change request? Thank you!
from sdk.
leonsenft
commented on June 29, 2024
LGTM 👍
from sdk.
Hixie
commented on June 29, 2024
no objection from me. cc @yjbanov
from sdk.
vsmenon
commented on June 29, 2024
lgtm
from sdk.
Related Issues (20)
- Failures on [dart2wasm] Use unsafeCast in a few places...Reland "[vm] Move `ResolveUri` to bin" HOT 1
- Analyzer data-based fix request HOT 2
- `dart compile js` fails with the newest SDK HOT 17
- Cannot resolve top-level methods with docimports HOT 4
- [Wildcard Variables] Update `DUPLICATE_DEFINTION` reporting
- CFE fails to report error when `super` is used in a redirecting constructor. HOT 2
- DevTools not serving properly on app refresh HOT 1
- [Wildcard Variables] Update `DUPLICATE_FIELD_FORMAL_PARAMETER` reporting
- `@internal` annotation does not supress `public_member_api_docs` lint on functions HOT 1
- Dart analyzer does not infer the correct type for generic record HOT 2
- Having true cancelable future HOT 2
- Simplify branch conditions based on ranges & simplify control flow afterwards if condition turns out to be constant
- Issue in number multiplication with 10, 20, etc HOT 4
- Feature Request: Add `--insert-ignore-comments` flag to `dart fix` command for existing code HOT 1
- [vm/core] `_GrowableList.add` has unnecessary bounds check
- docImports failing to allow for resolution in some flutter animation library code HOT 4
- Is that possible to set breakpoints in the macro code itself? HOT 2
- Implement augmentations HOT 2
- Support macros when analyzer is used as a library HOT 1
- Inability to Convert Dart BigInt to JSBigInt using new js_interop HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.