Giter Club home page Giter Club logo

Comments (10)

a-siva avatar a-siva commented on June 29, 2024

//cc @jakemac53

from sdk.

dart-github-bot avatar dart-github-bot commented on June 29, 2024

area-test, type-bug

The pkg/_macros/test/executor/executor_test tests are failing on Windows ARM64 and x64 configurations, resulting in a RuntimeError instead of the expected Pass.

from sdk.

devoncarew avatar devoncarew commented on June 29, 2024

around area-test might need to be made more explicit that it should prefer the affected functional area, or otherwise weighted down

I agree with that (and thanks for the feedback on the meta / triaging bot issue). Here, is it area-vm tests that are failing? We don't have a specific area for macros.; we're using area-language for non-implementation discussion issues.

We could improve the prompt for these 'test' cases. We're also not using the tuned model yet, just explicit directions in a prompt; switching to the tuned model should also improve accuracy here.

from sdk.

jakemac53 avatar jakemac53 commented on June 29, 2024

The area should be area-pkg afaik (the tests in question are in pkg/_macros).

from sdk.

jakemac53 avatar jakemac53 commented on June 29, 2024

@a-siva do you have a failure you can link me? I did recently land a fix for this test, and I am not sure how to validate if it was the same error or something different etc.

from sdk.

a-siva avatar a-siva commented on June 29, 2024

Here is the first time the failure showed up logs
(I believe it was a Timeout initially and then turned into a RuntimeError later).

from sdk.

devoncarew avatar devoncarew commented on June 29, 2024

The area should be area-pkg afaik (the tests in question are in pkg/_macros).

Yes, but area-pkg is not a great area- itself. It's not triaged - there's no team that does secondary triage on it or ultimately has responsibility for items in that area.

from sdk.

jakemac53 avatar jakemac53 commented on June 29, 2024

Ok yeah looking at the log, that is the one that should be fixed. Is this still failing?

from sdk.

a-siva avatar a-siva commented on June 29, 2024

It was failing on the windows bots until I created this issue and approved the failure

from sdk.

jakemac53 avatar jakemac53 commented on June 29, 2024

Moved this to the "no milestone/release" bucket. It isn't directly tied to any release and I haven't discovered any reasonable way to try and investigate the failure. I intend to just leave this as open tech debt for some time. There are no actual affected users, just a failing test in an environment that I can't reproduce.

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.