Giter Club home page Giter Club logo

Comments (2)

lrhn avatar lrhn commented on August 16, 2024

In general, it seems you are not allowed to call write while a flush is in progress.

Here you are not awaiting the flush, so the following write happens while the flust is in progress:

          // socket.write('Hello');
          // socket.flush();
          // socket.write('Goodbye');

Here you are scheduling a write to happen later, then calling flush, which means the former write happens
while the flust is in progress.

          // scheduleMicrotask(() => socket.write('Hello'));
          // await socket.flush();
          // scheduleMicrotask(() => socket.write('Goodbye'));

So at least it's consistent. I agree that it's not documented behavior.

from sdk.

larssn avatar larssn commented on August 16, 2024

I know I'm not awaiting flush. If multiple chunks of async code is using the same socket, awaiting a flush isn't always possible. Sure you can await it, but code in a different location might try to write at the same instance.

And these two examples are just the ones I was able to conjure up, I've seen more weird crashes in our production environment.

Basically it feels very unsafe, to call either write or flush.

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.