Exception Thrown with Camel Cased Embedded Attributes about spring-data-jpa-datatables HOT 2 CLOSED

Hi, thanks for your feedback!

You're absolutly right, applying toLowerCase to column.getData() does not make much sense, it's the column itself which should be cast to String and then applied lower().

ed6d755 should fix that, could you confirm please?

from spring-data-jpa-datatables.

Hey Damien,

I have pulled the latest software from the Git repository, and confirm that you have resolved the reported issue. As an FYI, you also fixed another issue regarding case-insensitive searches. Initially, when I attempted to search on a text field, the query generated was case sensitive (since the filter was set to ‘toLowerCase’). The search failed on a Postgres database, because the column was all upper case. I looked at one of your test cases that tested this feature, and notice you are using H2 embedded. I am not sure why the test case was passing, as H2 is case sensitive. However, after this fix, everything seems to be working.

Thank you once again for all of your hard work!

--Chris

From: Damien Arrachequesne [mailto:[email protected]]
Sent: Wednesday, March 30, 2016 7:48 PM
To: darrachequesne/spring-data-jpa-datatables [email protected]
Cc: Ciemier, Christopher (CCIEMIER) [email protected]
Subject: Re: [darrachequesne/spring-data-jpa-datatables] Exception Thrown with Camel Cased Embedded Attributes (#6)

Hi, thanks for your feedback!

You're absolutly right, applying toLowerCase to column.getData() does not make much sense, it's the column itself which should be cast to String and then applied lower().

ed6d755ed6d755 should fix that, could you confirm please?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-203688261

from spring-data-jpa-datatables.