Fetch join with pagination fails to append LIMIT in the generated HQL about spring-data-jpa-datatables HOT 8 CLOSED

@darrachequesne Yes, I got this working with the v3.0 version. Thanks a ton for the fix !

from spring-data-jpa-datatables.

@pshingavi @darrachequesne I am facing the same problem. Can any of you provide the solution. I couldn't find anything in the GitHub link available above.

from spring-data-jpa-datatables.

This is similar to the problem here : http://stackoverflow.com/questions/26901010/spring-data-jpa-eager-fetch-with-join-and-using-pagination-not-working

I see the below WARNING in my logs :

Log message is WARN org.hibernate.hql.internal.ast.QueryTranslatorImpl - HHH000104: firstResult/maxResults specified with collection fetch; applying in memory!

How can I achieve pagination in such case without any performance hit ?

from spring-data-jpa-datatables.

Are you applying any filtering/sorting on the lines? If not, you could lazily fetch the lines, after you've retrieved a list of Orders.

What's happening here (as you've certainly understood) is that, since Hibernate doesn't know how many lines it eventually needs, it fetches all those lines in memory.

from spring-data-jpa-datatables.

Thank you for the quick response :)

Yes I have a Specification which filters on the line items too.

from spring-data-jpa-datatables.

In that case, that line here https://github.com/darrachequesne/spring-data-jpa-datatables/blob/master/src/main/java/org/springframework/data/jpa/datatables/repository/SpecificationFactory.java#L106 might cause your issue, since it add a FETCH JOIN for every related attributes.

from spring-data-jpa-datatables.

That's correct.

Adamantly backtracking to use custom query using @query and Pageable in my Repository :(

from spring-data-jpa-datatables.

@pshingavi Hi! I've just published v3.0, could you please try it, and see whether it fixes your issue please?

from spring-data-jpa-datatables.