Comments (6)
Yeah, good point. Ok, let's not have a separate js_of_ocaml lib until we have a good reason to do otherwise.
(If anyone is interested in fixing this, it can be fixed by removing the Str dependency, and updating the readme to indicate we don't need a js_of_ocaml version).
from tablecloth.
Here is an inefficient POC.
let split ~(on : string) (s : string) : string list =
let pat = String.Search_pattern.create on in
let len = String.length on in
String.Search_pattern.index_all pat ~may_overlap:false ~in_:s
|> List.fold_map ~init:0 ~f:(fun x y -> y + len , (x,y))
|> (fun (last,l) -> l @ [last, String.length s ])
|> List.map ~f:(fun (x,y) -> String.sub ~pos:x ~len:(y - x) s)
from tablecloth.
Great! Would love to see someone contribute the Str change!
I think there might be value in having two packages, even if they have the same contents, as this may let us specialize some implementations or types for js_of_ocaml. Though for our codebase, we don't really pay attention to the js_of_ocaml build, it "just works". WDYT?
from tablecloth.
Having a single package allows one to build libraries without having to specialize for a specific target.
Without that, one would need to provide multiple copies for every library ? like library_for_doing_blah_js
, library_for_doing_blah_native
, .. ?
from tablecloth.
Str
is now compatible with js_of_ocaml. Tablecloth should work out of the box with js_of_ocaml
from tablecloth.
Thanks @hhugo!
from tablecloth.
Related Issues (20)
- Missing functions HOT 2
- List.insertAt not working HOT 1
- Consistent index edge-case behaviour HOT 1
- Update website HOT 1
- List.chunksOf drops remaining elements HOT 2
- Website sidebar navigation HOT 1
- Looking for new maintainers HOT 7
- Make a spec/compatibility page
- publish 0.0.8 on npm HOT 2
- publish 0.0.8 on opam HOT 2
- Merge next branch HOT 1
- Redo the documentation
- Split the repo into different repos HOT 2
- Move ocaml code into darklang/tablecloth-ocaml-base HOT 3
- Move rescript code into tablecloth-rescript HOT 2
- Move fsharp code into darklang/tablecloth-fsharp HOT 1
- Create yaml file with test cases
- Create spec
- Replace website with simple html/js/css
- Fix "get started" link on website
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tablecloth.