UB from a crater run about ddh HOT 11 CLOSED

Hey, thanks for the bug report. I wonder if this issue isn't related to a symlink handling bug discovered in #23
Is it possible to rerun the crater test with a feature branch?

from ddh.

I don't think that would be possible.

from ddh.

Dang that's unfortunate. I'm not sure what I can do to fix this without a test case :(

from ddh.

Closing this issue do not having possible solution merged and no replicable test case.

from ddh.

@darakian I think this is a bug in crossbeam-epoch; the crate seems to depend on v0.7.1. v0.7.2 fixes a critical bug.

I am wondering why that version was not picked automatically? crossbeam-epoch is a transitive dependency it seems.

(Btw, the relevant rustc change here is rust-lang/rust#71274.)

from ddh.

The dependency seems to be via rayon. But that doesn't explain why it did not use v0.7.2.

Crater has been testing ddh-0.10.9; unfortunately there seem to be no tags in this repository so I cannot easily look at the code as it was back then.

from ddh.

@RalfJung Thanks for the follow up and sorry about the lack of tags. The dependencies at the time of 0.10.9 were

[dependencies]
clap = "2.33.0"
rayon = "1.1"
serde = "1.0"
serde_json = "1.0"
serde_derive = "1.0"
siphasher = "0.3"
nohash-hasher = "0.1.1"

Is it just 0.10.9 that shows this problem? If so that's certainly odd as 0.11.0 was only a license change release and is identical code.

Here's a link to the repo on 0.10.9 commit if it helps
https://github.com/darakian/ddh/tree/1d4f4922ba24a49c31d3359e584df9903c22b87c

from ddh.

0.10.9 was the latest version at the time the test was run, so I cannot say if newer versions still show this problem.

In your local lockfile, which version of crossbeam-epoch does it use? cargo tree can help figure that out.

from ddh.

Looks like 0.8.2

jon~/G/!/ddh:(HEAD detached at 1d4f492)❯❯❯ cargo tree | rg crossbeam
│   ├── crossbeam-deque v0.7.3
│   │   ├── crossbeam-epoch v0.8.2
│   │   │   ├── crossbeam-utils v0.7.2
│   │   ├── crossbeam-utils v0.7.2 (*)
│       ├── crossbeam-deque v0.7.3 (*)
│       ├── crossbeam-queue v0.2.3
│       │   ├── crossbeam-utils v0.7.2 (*)
│       ├── crossbeam-utils v0.7.2 (*)

from ddh.

Okay. I think we can consider this issue resolved then, and the next time around crater should pick up the latest version of crossbeam-epoch I hope.

from ddh.

🤞

Thanks again for reaching out :)

from ddh.