Giter Club home page Giter Club logo

Comments (9)

elena-kolevska avatar elena-kolevska commented on September 25, 2024 1

@sicoyle is this good to be closed?

from dapr.

elena-kolevska avatar elena-kolevska commented on September 25, 2024

/assign

from dapr.

Cherrs avatar Cherrs commented on September 25, 2024

I am preparing to use dapr_placement.cluster.forceInMemoryLog=true in a production environment. I haven't enabled high availability (HA) before. This makes me very concerned.

from dapr.

sicoyle avatar sicoyle commented on September 25, 2024

I updated the title and description to reflect that we actually use on-disk raft logs. I saw the dapr flag default being in memory so assumed that's what we were using (see here); however, we actually use the helm value default which sets placement to on-disk for raft logs. So, the issue in my case is specific to on-disk raft logs.

ping @Cherrs - just wanted to let you know the update :)

from dapr.

jjcollinge avatar jjcollinge commented on September 25, 2024

I updated the title and description to reflect that we actually use on-disk raft logs. I saw the dapr flag default being in memory so assumed that's what we were using (see here); however, we actually use the helm value default which sets placement to on-disk for raft logs. So, the issue in my case is specific to on-disk raft logs.

ping @Cherrs - just wanted to let you know the update :)

Isn't this Helm default (forceInMemoryLog=false) only actually used when the HA value is also set to true? Check the statefulset manifest

from dapr.

elena-kolevska avatar elena-kolevska commented on September 25, 2024

Yeah, that's correct, we can only have on disk log when we have a placement cluster:

{{- if or (eq .Values.global.ha.enabled true) (eq .Values.ha true) }}
        - "--id"
        - "$(PLACEMENT_ID)"
        - "--initial-cluster"
        - {{ template "dapr_placement.initialcluster" . }}
  {{- if eq .Values.cluster.forceInMemoryLog false }}
        - "--raft-logstore-path"
    {{- if eq .Values.global.daprControlPlaneOs "windows" }}
        - "{{ .Values.cluster.logStoreWinPath }}\\cluster-v2-$(PLACEMENT_ID)"
    {{- else }}
        - "{{ .Values.cluster.logStorePath }}/cluster-v2-$(PLACEMENT_ID)"
    {{- end }}
  {{- end }}
{{- end }}

from dapr.

dapr-bot avatar dapr-bot commented on September 25, 2024

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

from dapr.

elena-kolevska avatar elena-kolevska commented on September 25, 2024

Without more details log it's not possible to know for sure, but I believe what we see in this issue is a compounded effect of the problems explained and solved in these two PRs:

from dapr.

cgillum avatar cgillum commented on September 25, 2024

From the discussion, it sounds like this can be closed.

from dapr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.